Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop python 3.8 support #3143

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Drop python 3.8 support #3143

merged 3 commits into from
Nov 24, 2024

Conversation

ankith26
Copy link
Member

@ankith26 ankith26 commented Oct 5, 2024

Python 3.8 is EOL. We can now consider dropping it.

The biggest advantage of doing this is nicer type stubs.

@ankith26 ankith26 requested a review from a team as a code owner October 5, 2024 16:30
@bilhox
Copy link
Contributor

bilhox commented Oct 5, 2024

Could we first release 2.5.2 then drop the support for 3.8 ?

@ankith26 ankith26 force-pushed the ankith26-drop-py38 branch from 166c88d to 235b346 Compare October 5, 2024 16:43
@damusss damusss added Code quality/robustness Code quality and resilience to changes dependencies labels Oct 5, 2024
@Starbuck5
Copy link
Member

I agree with bilhox, no rush to drop it.

@ankith26
Copy link
Member Author

ankith26 commented Oct 6, 2024

Could we first release 2.5.2 then drop the support for 3.8 ?

Yeah definitely. I just wanted to put this PR out there. We can wait a couple of months on this.

@bilhox bilhox added this to the 2.5.3 milestone Oct 13, 2024
@ankith26 ankith26 force-pushed the ankith26-drop-py38 branch 2 times, most recently from a93bc11 to b3609cc Compare October 23, 2024 15:51
@Starbuck5 Starbuck5 mentioned this pull request Nov 3, 2024
Closed
@ankith26 ankith26 mentioned this pull request Nov 3, 2024
Merged
zoldalma999
zoldalma999 reviewed Nov 16, 2024
View reviewed changes
src_py/_debug.py Outdated Show resolved Hide resolved
zoldalma999
zoldalma999 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@zoldalma999 zoldalma999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

damusss
damusss approved these changes Nov 24, 2024
View reviewed changes
Copy link
Contributor

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LawesomeTM

@damusss damusss merged commit 2b195a7 into main Nov 24, 2024
25 checks passed
@damusss damusss deleted the ankith26-drop-py38 branch November 24, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starbuck5 Starbuck5 Starbuck5 left review comments

@damusss damusss damusss approved these changes

@zoldalma999 zoldalma999 zoldalma999 approved these changes

Assignees
No one assigned
Labels
Code quality/robustness Code quality and resilience to changes dependencies
Projects
None yet
Milestone
2.5.3
Development

Successfully merging this pull request may close these issues.
5 participants
@ankith26 @bilhox @Starbuck5 @zoldalma999 @damusss